Adam Litke has posted comments on this change. Change subject: Live Merge: Mark active layer ILLEGAL before pivoting ......................................................................
Patch Set 2: -Verified (1 comment) http://gerrit.ovirt.org/#/c/31787/2/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 1853: subChainTailVol = sdDom.produceVolume(imgUUID, subChain[-1]) Line 1854: children = subChainTailVol.getChildren() Line 1855: for childID in children: Line 1856: sdDom.produceVolume(imgUUID, childID).setParentMeta(dstParent) Line 1857: if not children: > With the current code it's hard to understand that "for" and "if not childr you're right. Updating. Line 1858: self.log.debug("Leaf volume is being removed from the chain. " Line 1859: "Marking it ILLEGAL to prevent data corruption") Line 1860: subChainTailVol.setLegality(volume.ILLEGAL_VOL) Line 1861: -- To view, visit http://gerrit.ovirt.org/31787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97ce8fbdfad7c81181a206f160ffdd647c552d4d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
