Adam Litke has posted comments on this change. Change subject: Live Merge: Mark active layer ILLEGAL before pivoting ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/31787/3/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 1849: if len(subChain) == 0: Line 1850: return Line 1851: Line 1852: dstParent = sdDom.produceVolume(imgUUID, subChain[0]).getParent() Line 1853: subChainTailVol = sdDom.produceVolume(imgUUID, subChain[-1]) > I think it will be more clear as: Done Line 1854: children = subChainTailVol.getChildren() Line 1855: if not children: Line 1856: self.log.debug("Leaf volume is being removed from the chain. " Line 1857: "Marking it ILLEGAL to prevent data corruption") -- To view, visit http://gerrit.ovirt.org/31787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97ce8fbdfad7c81181a206f160ffdd647c552d4d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
