Francesco Romani has posted comments on this change. Change subject: Live Merge: Mark active layer ILLEGAL before pivoting ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/31787/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5717: """ Line 5718: Returns True if the last cleanup phase succeeded and the job can be Line 5719: removed. Line 5720: """ Line 5721: return self.success and self.mode == self.MODE_CLEANUP same comment as per revision 2. Same reasoning (ACK'ing anyway, seems harmless if my guess is wrong) Line 5722: Line 5723: Line 5724: def _devicesWithAlias(domXML): Line 5725: return vmxml.filter_devices_with_alias(vmxml.all_devices(domXML)) -- To view, visit http://gerrit.ovirt.org/31787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97ce8fbdfad7c81181a206f160ffdd647c552d4d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
