Nir Soffer has posted comments on this change. Change subject: vm: return diskMapping on status() ......................................................................
Patch Set 3: (2 comments) Looks ok except the schema. http://gerrit.ovirt.org/#/c/31700/3/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3488: 'data': {'*vmList': ['UUID']}, Line 3489: 'returns': ['UUID']} Line 3490: Line 3491: ## Line 3492: # @guestDiskMappingInfoMap: Type names should use CammelCase - use Guest... This should be a type, not a map, so we can document the names of the keys. Otherwise you cannot tell from this description which keys are available. See TaskStatus for example how to define this. Line 3493: # Line 3494: # disk mapping information indexed by property name. Line 3495: # Line 3496: # Since: 4.15.0 Line 3498: {'map': 'guestDiskMappingInfoMap', Line 3499: 'key': 'str', 'value': 'str'} Line 3500: Line 3501: ## Line 3502: # @guestDisksMappingMap: Type names should use CammelCase - use Guest... Line 3503: # Line 3504: # guest disks mapping information indexed by serial. Line 3505: # Line 3506: # Since: 4.15.0 -- To view, visit http://gerrit.ovirt.org/31700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia68ff3c36ba91cde893876a16fc6702419a60d49 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
