Francesco Romani has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property ......................................................................
Patch Set 7: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/32796/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2872 Line 2873 Line 2874 Line 2875 Line 2876 > this comment is unrelated to sdIds maintenance - please keep it. It was add I spent quite some time figuring out my score to this patch for this comment alone. I can get away with this removal (hence my +1) since the else clause is now gone. On the other hand, it's also true that the removal of this comment doesn't belong to this patch, and this documents a quite dark corner of VDSM (got bitten from this quite recently), and we can keep this by just de-indent the comment block of one level. Other than that, patch looks fine. -- To view, visit http://gerrit.ovirt.org/32796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabio Pliger <fabio.pli...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Fabio Pliger <fabio.pli...@gmail.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
