Nir Soffer has posted comments on this change. Change subject: vm: implement VM.sdIds as read-only property ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/32796/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2872 Line 2873 Line 2874 Line 2875 Line 2876 > this comment is unrelated to sdIds maintenance - please keep it. It was add The comment was needed when we were adding domain ids, and *not* starting disk stats collection. Now the only place doing this is preparePath, so this comment is not much useful any more. Line 5588: def sdIds(self): Line 5589: """ Line 5590: Returns a list of the ids of the storage domains in use by the VM. Line 5591: """ Line 5592: return set(device.domainID for device in self._devices[DISK_DEVICES] > The removed code had an additional check for Lets keep the pointless 'disk' check, and remove it globally in another patch from all other places. Line 5593: if isVdsmImage(device)) Line 5594: Line 5595: Line 5596: class LiveMergeCleanupThread(threading.Thread): -- To view, visit http://gerrit.ovirt.org/32796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabio Pliger <fabio.pli...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Fabio Pliger <fabio.pli...@gmail.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches