Nir Soffer has posted comments on this change.
Change subject: jsonrpc: Bridge.py reducing logging level
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
This fix is not good enough, leaving unneeded and unhelpful messages in the
logs.
Thread-948::DEBUG::2014-10-12 22:16:20,684::Bridge::212::root::(_typeFixup)
Fixing up type VmDevice
Thread-948::DEBUG::2014-10-12 22:16:20,685::Bridge::469::root::(fieldClone)
fieldClone: type -> deviceType
Thread-948::DEBUG::2014-10-12 22:16:20,685::Bridge::212::root::(_typeFixup)
Fixing up type VmDevice
Thread-948::DEBUG::2014-10-12 22:16:20,685::Bridge::469::root::(fieldClone)
fieldClone: type -> deviceType
Thread-948::DEBUG::2014-10-12 22:16:20,685::Bridge::212::root::(_typeFixup)
Fixing up type VmDevice
Thread-948::DEBUG::2014-10-12 22:16:20,685::Bridge::469::root::(fieldClone)
fieldClone: type -> deviceType
Thread-948::DEBUG::2014-10-12 22:16:20,685::Bridge::212::root::(_typeFixup)
Fixing up type VmDevice
Thread-948::DEBUG::2014-10-12 22:16:20,685::Bridge::469::root::(fieldClone)
fieldClone: type -> deviceType
Thread-948::DEBUG::2014-10-12 22:16:20,685::Bridge::212::root::(_typeFixup)
Fixing up type VmDevice
Thread-948::DEBUG::2014-10-12 22:16:20,685::Bridge::469::root::(fieldClone)
fieldClone: type -> deviceType
Thread-948::DEBUG::2014-10-12 22:16:20,686::Bridge::212::root::(_typeFixup)
Fixing up type VmDevice
Thread-948::DEBUG::2014-10-12 22:16:20,686::Bridge::469::root::(fieldClone)
fieldClone: type -> deviceType
Thread-948::DEBUG::2014-10-12 22:16:20,686::Bridge::212::root::(_typeFixup)
Fixing up type VmDevice
Thread-948::DEBUG::2014-10-12 22:16:20,686::Bridge::469::root::(fieldClone)
fieldClone: type -> deviceType
Thread-948::DEBUG::2014-10-12 22:16:20,686::Bridge::212::root::(_typeFixup)
Fixing up type VmDevice
Thread-948::DEBUG::2014-10-12 22:16:20,686::Bridge::469::root::(fieldClone)
fieldClone: type -> deviceType
Thread-948::DEBUG::2014-10-12 22:16:20,686::Bridge::212::root::(_typeFixup)
Fixing up type VmDevice
Thread-948::DEBUG::2014-10-12 22:16:20,686::Bridge::469::root::(fieldClone)
fieldClone: type -> deviceType
Thread-948::DEBUG::2014-10-12 22:16:20,686::Bridge::212::root::(_typeFixup)
Fixing up type VmDevice
Thread-948::DEBUG::2014-10-12 22:16:20,686::Bridge::469::root::(fieldClone)
fieldClone: type -> deviceType
Thread-948::DEBUG::2014-10-12 22:16:20,686::Bridge::212::root::(_typeFixup)
Fixing up type VmDevice
Thread-948::DEBUG::2014-10-12 22:16:20,687::Bridge::469::root::(fieldClone)
fieldClone: type -> deviceType
Thread-948::DEBUG::2014-10-12 22:16:20,687::Bridge::212::root::(_typeFixup)
Fixing up type VmDevice
Thread-948::DEBUG::2014-10-12 22:16:20,687::Bridge::469::root::(fieldClone)
fieldClone: type -> deviceType
Thread-948::DEBUG::2014-10-12 22:16:20,687::Bridge::212::root::(_typeFixup)
Fixing up type VmDevice
Thread-948::DEBUG::2014-10-12 22:16:20,687::Bridge::469::root::(fieldClone)
fieldClone: type -> deviceType
Yes, these are not warning anymore, but they are not needed. Please remove them.
There is no point in opening another bug for this and wasting everyone time
again; lets have a complete fix now.
http://gerrit.ovirt.org/#/c/34097/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 208: itemList = [obj]
Line 209:
Line 210: for item in itemList:
Line 211: if symTypeName in typefixups:
Line 212: logging.debug("Fixing up type %s", symTypeName)
This is not a complete fix, we are left with log of unhelpful debug logs.
Please explain why these messages are needed, and why having
unit tests for this function is not good enough.
Line 213: typefixups[symTypeName](item)
Line 214: for (k, v) in symbol.get('data', {}).items():
Line 215: k = self._symNameFilter(k)
Line 216: if k in item:
Line 466: }
Line 467:
Line 468:
Line 469: def fieldClone(oldName, newName, obj):
Line 470: logging.debug("fieldClone: %s -> %s", oldName, newName)
This is not a complete fix, we are left with log of unhelpful debug logs.
Please explain why these messages are needed, and why having
unit tests for this function is not good enough.
Line 471: if oldName in obj:
Line 472: obj[newName] = obj[oldName]
Line 473: elif newName in obj:
Line 474: obj[oldName] = obj[newName]
--
To view, visit http://gerrit.ovirt.org/34097
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69caf6ce30746ee3e8e843de8dcdddb793c55e2b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
