Nir Soffer has posted comments on this change. Change subject: jsonrpc: Bridge.py reducing logging level ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34097/2/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 209: Line 210: for item in itemList: Line 211: if symTypeName in typefixups: Line 212: logging.debug("Fixing up type %s for item %s", Line 213: symTypeName, item) What can go wrong with this "fixup"? Do we have unit tests verifying this? Why do we need to see a log for each fixup? Can the result change between requests? This log looks like leftover from early development stage, where you add log to make sure the code works, and you have no tests. If you need to debug this, you can add such log on a local machine, or log the output of vdsm and the input of the engine. Not clear why this change needs a log in a production environment. Line 214: typefixups[symTypeName](item) Line 215: for (k, v) in symbol.get('data', {}).items(): Line 216: k = self._symNameFilter(k) Line 217: if k in item: -- To view, visit http://gerrit.ovirt.org/34097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69caf6ce30746ee3e8e843de8dcdddb793c55e2b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
