Nir Soffer has posted comments on this change. Change subject: jsonrpc: Bridge.py reducing logging level ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34097/1/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 208: itemList = [obj] Line 209: Line 210: for item in itemList: Line 211: if symTypeName in typefixups: Line 212: logging.debug("Fixing up type %s", symTypeName) > There are few types that require fixup defined in typefixups struct which m I understand this, but this debug log is not helpful - there is no context to this message, and I don't see how does it help you to debug the system. These types of logs are only making it hard for other people to work with real useful messages. Line 213: typefixups[symTypeName](item) Line 214: for (k, v) in symbol.get('data', {}).items(): Line 215: k = self._symNameFilter(k) Line 216: if k in item: -- To view, visit http://gerrit.ovirt.org/34097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69caf6ce30746ee3e8e843de8dcdddb793c55e2b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
