Nir Soffer has posted comments on this change. Change subject: External hypervisor VMs integration ......................................................................
Patch Set 16: (3 comments) http://gerrit.ovirt.org/#/c/33309/16/tests/v2vTests.py File tests/v2vTests.py: Line 82: @MonkeyPatch(libvirtconnection, 'open_connection', hypervisorConnect) Line 83: def testGetExternalVMList(self): Line 84: vm = v2v.getExternalVMList('esx://mydomain', 'user', Line 85: 'password')[0] Line 86: self.assertTrue(vm is not None) How can vm be None? Line 87: self.assertEquals(vm['vmId'], '564d7cb4-8e3d-06ec-ce82-7b2b13c6a611') Line 88: self.assertEquals(vm['memSize'], 2048) Line 89: self.assertEquals(vm['smp'], 1) Line 90: self.assertTrue(vm['disks'] is not None) Line 86: self.assertTrue(vm is not None) Line 87: self.assertEquals(vm['vmId'], '564d7cb4-8e3d-06ec-ce82-7b2b13c6a611') Line 88: self.assertEquals(vm['memSize'], 2048) Line 89: self.assertEquals(vm['smp'], 1) Line 90: self.assertTrue(vm['disks'] is not None) How can disks be None? Maybe check len(vm['disks']) == 1 ? Line 91: self.assertTrue(vm['networks'] is not None) Line 92: disk = vm['disks'][0] Line 93: self.assertEquals(disk['dev'], 'sda') Line 94: self.assertEquals(disk['alias'], '[datastore1] RHEL/RHEL.vmdk') Line 87: self.assertEquals(vm['vmId'], '564d7cb4-8e3d-06ec-ce82-7b2b13c6a611') Line 88: self.assertEquals(vm['memSize'], 2048) Line 89: self.assertEquals(vm['smp'], 1) Line 90: self.assertTrue(vm['disks'] is not None) Line 91: self.assertTrue(vm['networks'] is not None) Same Line 92: disk = vm['disks'][0] Line 93: self.assertEquals(disk['dev'], 'sda') Line 94: self.assertEquals(disk['alias'], '[datastore1] RHEL/RHEL.vmdk') Line 95: network = vm['networks'][0] -- To view, visit http://gerrit.ovirt.org/33309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
