Shahar Havivi has posted comments on this change. Change subject: External hypervisor VMs integration ......................................................................
Patch Set 18: (1 comment) http://gerrit.ovirt.org/#/c/33309/18/vdsm/v2v.py File vdsm/v2v.py: Line 30: libvirt.VIR_DOMAIN_PAUSED: vmstatus.PAUSED, Line 31: libvirt.VIR_DOMAIN_SHUTDOWN: vmstatus.POWERING_DOWN, Line 32: libvirt.VIR_DOMAIN_SHUTOFF: vmstatus.DOWN, Line 33: libvirt.VIR_DOMAIN_CRASHED: 'Crashed', Line 34: libvirt.VIR_DOMAIN_PMSUSPENDED: 'PMSuspended'} > This is clear, but this map blongs to vmstatus, so other code can use it as ok, I will add the absent statuses to vmstatus Line 35: Line 36: Line 37: def getExternalVMList(uri, username, password): Line 38: conn = libvirtconnection.open_connection(uri=uri, -- To view, visit http://gerrit.ovirt.org/33309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
