Francesco Romani has posted comments on this change. Change subject: jsonrpc: switch to the simplejson module ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35024/2/vdsm.spec.in File vdsm.spec.in: Line 97: %if 0%{?rhel} == 7 Line 98: BuildRequires: python-simplejson >= 3.3.3 Line 99: %else # fedora Line 100: BuildRequires: python-simplejson >= 3.5.3 Line 101: %endif > why do we need those specific versions? isn't that enough to request for py The only requirement we have is >= 2.0.9 on CentOS/RHEL 6 to get these speedups. Since the version shipped on these version is exactly 2.0.9, we can probably drop the version requirement and just require simplejson. Line 102: %endif Line 103: Line 104: # Autotools BuildRequires Line 105: %if 0%{?enable_autotools} -- To view, visit http://gerrit.ovirt.org/35024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic17aa6d75cef933ee36e002c03732aab14b39648 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
