Nir Soffer has posted comments on this change.

Change subject: jsonrpc: switch to the simplejson module
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/35024/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 17: from Queue import Queue
Line 18: from weakref import ref
Line 19: from threading import Lock, Event
Line 20: 
Line 21: import simplejson
> Is it a drop in replacement for json? If so then maybe:
+1
Line 22: 
Line 23: from vdsm.utils import traceback
Line 24: 
Line 25: __all__ = ["tcpReactor"]


-- 
To view, visit http://gerrit.ovirt.org/35024
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic17aa6d75cef933ee36e002c03732aab14b39648
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dima Kuznetsov <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to