Francesco Romani has posted comments on this change. Change subject: jsonrpc: switch to the simplejson module ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/35024/2/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 17: from Queue import Queue Line 18: from weakref import ref Line 19: from threading import Lock, Event Line 20: Line 21: import simplejson > Is it a drop in replacement for json? If so then maybe: will change. Line 22: Line 23: from vdsm.utils import traceback Line 24: Line 25: __all__ = ["tcpReactor"] http://gerrit.ovirt.org/#/c/35024/2/vdsm.spec.in File vdsm.spec.in: Line 97: %if 0%{?rhel} == 7 Line 98: BuildRequires: python-simplejson >= 3.3.3 Line 99: %else # fedora Line 100: BuildRequires: python-simplejson >= 3.5.3 Line 101: %endif > So lets use ">= 2.0.9" on all platforms? Switched to simpler 'python-simplejson >= 2.0.9' for all platforms. Line 102: %endif Line 103: Line 104: # Autotools BuildRequires Line 105: %if 0%{?enable_autotools} -- To view, visit http://gerrit.ovirt.org/35024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic17aa6d75cef933ee36e002c03732aab14b39648 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches