Francesco Romani has posted comments on this change. Change subject: External hypervisor VMs integration ......................................................................
Patch Set 30: (1 comment) http://gerrit.ovirt.org/#/c/33309/30/vdsm/virt/vmstatus.py File vdsm/virt/vmstatus.py: Line 25: DOWN = 'Down' Line 26: MIGRATION_DESTINATION = 'Migration Destination' Line 27: MIGRATION_SOURCE = 'Migration Source' Line 28: PAUSED = 'Paused' Line 29: POWERING_DOWN = 'Powering down' > this submodule is supposed to define vdsm's API, which is not exactly like I agreed to move the new statuses here. I briefly thought about possible confusion with older Engines, and concluded that as far as the new statuses are used only in the new get_external_vms flow, they should be harmless. But on second thought yes, I may have deluded myself. The above may work but it is fragile. Probably Dan's solution is safer. Line 30: POWERING_UP = 'Powering up' Line 31: POWER_MANAGEMENT_SUSPENDED = 'PMSuspended' Line 32: REBOOT_IN_PROGRESS = 'RebootInProgress' Line 33: RESTORING_STATE = 'Restoring state' -- To view, visit http://gerrit.ovirt.org/33309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
