Dan Kenigsberg has posted comments on this change. Change subject: External hypervisor VMs integration ......................................................................
Patch Set 31: (1 comment) http://gerrit.ovirt.org/#/c/33309/31/vdsm/v2v.py File vdsm/v2v.py: Line 49: ret.append(params) Line 50: return ret Line 51: Line 52: Line 53: def _memToMb(size, unit): yes, this function converts to MiB, so it should be named _mem_to_MiB or something like that. Line 54: lunit = unit.lower() Line 55: if lunit in ('bytes', 'b'): Line 56: return size / 1024 / 1024 Line 57: elif lunit in ('kib', 'k'): -- To view, visit http://gerrit.ovirt.org/33309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
