Dan Kenigsberg has posted comments on this change. Change subject: External hypervisor VMs integration ......................................................................
Patch Set 31: (1 comment) http://gerrit.ovirt.org/#/c/33309/31/vdsm/virt/vmstatus.py File vdsm/virt/vmstatus.py: Line 31: POWER_MANAGEMENT_SUSPENDED = 'PMSuspended' Line 32: REBOOT_IN_PROGRESS = 'RebootInProgress' Line 33: RESTORING_STATE = 'Restoring state' Line 34: SAVING_STATE = 'Saving State' Line 35: UNKNOWN = 'Unknown' Even if the statuses dict stays here, we should not define needless vdsm states, such as UNKNOWN and POWER_MANAGEMENT_SUSPENDED. And how about v2v module returning libvirt enums instead of translated strings? Line 36: UP = 'Up' Line 37: WAIT_FOR_LAUNCH = 'WaitForLaunch' Line 38: Line 39: statuses = {libvirt.VIR_DOMAIN_NOSTATE: UNKNOWN, -- To view, visit http://gerrit.ovirt.org/33309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
