Dan Kenigsberg has posted comments on this change. Change subject: teach delNetworks to remove a network entity under a bridge ......................................................................
Patch Set 8: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/35921/8/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1160: link = ipwrapper.getLink(NETWORK_NAME) Line 1161: return link.index Line 1162: Line 1163: with dummyIf(2) as nics: Line 1164: first, second = nics Calling this STANDARD would hint that this is not expected to ever chang Line 1165: standard = 1500 Line 1166: first_net = {NETWORK_NAME: dict(bridged=True, nic=first, Line 1167: mtu=standard)} Line 1168: status, msg = self.vdsm_net.setupNetworks(first_net, {}, NOCHK) http://gerrit.ovirt.org/#/c/35921/8/vdsm/network/api.py File vdsm/network/api.py: Line 454: net_ent_to_remove = net_ent.port Line 455: if net_ent_to_remove is not None: Line 456: # this is a hack. Line 457: # we disconnect the underlying device (bond/vlan/nic) from the Line 458: # bridge so that the configurator will allow it to be removed > Please start the comment by explaining first what the problem in the config I'm not sure that a FIXME is in place - as I don't know of a cleaner fix for this Line 459: _delete_bridge_interface(network, net_ent_to_remove.name) Line 460: else: Line 461: net_ent_to_remove = net_ent Line 462: -- To view, visit http://gerrit.ovirt.org/35921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6bb891f23ef4550f90c6c7b057aef6302cf435c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches