Dan Kenigsberg has posted comments on this change. Change subject: teach delNetworks to remove a network entity under a bridge ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/35921/10/vdsm/network/api.py File vdsm/network/api.py: Line 455: if net_ent_to_remove is not None: Line 456: # the configurator will not allow us to remove a bridge interface Line 457: # (be it vlan, bond or nic) unless it is not used anymore. Since Line 458: # we are interested to leave the bridge here, we have to disconnect Line 459: # it from the device so that the configurator will allow it's English: it's --> its. Line 460: # removal. Line 461: _delete_bridge_interface(network, net_ent_to_remove.name) Line 462: else: Line 463: net_ent_to_remove = net_ent Line 457: # (be it vlan, bond or nic) unless it is not used anymore. Since Line 458: # we are interested to leave the bridge here, we have to disconnect Line 459: # it from the device so that the configurator will allow it's Line 460: # removal. Line 461: _delete_bridge_interface(network, net_ent_to_remove.name) please try ipwrapper.linkSet(net_ent_to_remove.name, ['nomaster']) EXT_BRCTL is kinda out-of-fashion, so maybe we shouldn't add a wrapper for it nowadays. Line 462: else: Line 463: net_ent_to_remove = net_ent Line 464: Line 465: # We must first remove the libvirt network and then the network entity. -- To view, visit http://gerrit.ovirt.org/35921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6bb891f23ef4550f90c6c7b057aef6302cf435c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
