Petr Horáček has posted comments on this change.

Change subject: teach delNetworks to remove a network entity under a bridge
......................................................................


Patch Set 9: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/35921/9/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1174:             second_net = {NETWORK_NAME: dict(bridged=True, 
nic=second,
Line 1175:                                              mtu=BIG)}
Line 1176:             status, msg = self.vdsm_net.setupNetworks(second_net, 
{}, NOCHK)
Line 1177:             self.assertEquals(status, SUCCESS, msg)
Line 1178:             # the kernel bridge driver automatically updates the he 
bridge to
'updates the he bridge' (not sure if typo or i just don't know what does it 
mean)
Line 1179:             # the new minimum MTU of all of it's connected interfaces
Line 1180:             self.assertMtu(BIG, NETWORK_NAME, second)
Line 1181:             self.assertEquals(bridge_index, get_bridge_index())
Line 1182: 


-- 
To view, visit http://gerrit.ovirt.org/35921
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6bb891f23ef4550f90c6c7b057aef6302cf435c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibar...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to