Shahar Havivi has posted comments on this change. Change subject: External hypervisor VMs integration ......................................................................
Patch Set 34: (3 comments) http://gerrit.ovirt.org/#/c/33309/34/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 404: 'Host_getCapabilities': {'ret': Host_getCapabilities_Ret}, Line 405: 'Host_getConnectedStoragePools': {'ret': 'poollist'}, Line 406: 'Host_getDeviceList': {'ret': 'devList'}, Line 407: 'Host_getDevicesVisibility': {'ret': 'visibility'}, Line 408: 'Host_getExternalVMs': {'call': Host_getExternalVMs_Call, 'ret': 'vmList'}, > You are ok only with having 'ret' here. Done Line 409: 'Host_getHardwareInfo': {'ret': 'info'}, Line 410: 'Host_getLVMVolumeGroups': {'ret': 'vglist'}, Line 411: 'Host_getRoute': {'ret': 'info'}, Line 412: 'Host_getStats': {'ret': 'info'}, http://gerrit.ovirt.org/#/c/33309/34/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3594: {'map': 'GuestDisksMappingMap', Line 3595: 'key': 'str', 'value': 'GuestDiskMappingInfo'} Line 3596: Line 3597: ## Line 3598: # @ExternalDiskInfo: > General: Please align arg description inline like with other verbs Done Line 3599: # Line 3600: # Disk information from external source Line 3601: # Line 3602: # @dev: #optional guest device name (sda, sdb, etc) http://gerrit.ovirt.org/#/c/33309/34/vdsm/v2v.py File vdsm/v2v.py: Line 28: ''' Unexpected error while parsing libvirt domain xml ''' Line 29: pass Line 30: Line 31: Line 32: def get_external_VMs(uri, username, password): > Please see my comment in version 33: yes, I did apply it... I think that by merging my next patch I override it back to upper case. Thanks Line 33: conn = libvirtconnection.open_connection(uri=uri, Line 34: username=username, Line 35: passwd=password) Line 36: with closing(conn): -- To view, visit http://gerrit.ovirt.org/33309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3 Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
