Dan Kenigsberg has posted comments on this change. Change subject: External hypervisor VMs integration ......................................................................
Patch Set 36: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/33309/36/vdsm/v2v.py File vdsm/v2v.py: Line 112: d['alias'] = source.get('file') Line 113: params['disks'].append(d) Line 114: Line 115: Line 116: def _add_networks(root, params): much nicer names, thanks. Line 117: params['networks'] = [] Line 118: interfaces = root.findall('.//interface') Line 119: for iface in interfaces: Line 120: i = {} -- To view, visit http://gerrit.ovirt.org/33309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3 Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
