Shahar Havivi has posted comments on this change. Change subject: External hypervisor VMs integration ......................................................................
Patch Set 35: (1 comment) http://gerrit.ovirt.org/#/c/33309/35/vdsm/v2v.py File vdsm/v2v.py: Line 46: try: Line 47: _add_general_info(root, params) Line 48: except InvalidVMConfiguration as e: Line 49: logging.error('error parsing domain xml, msg: %s xml: %s', Line 50: e.message, vm.XMLDesc(0)) > This will return vm info *without* or with partial general info. Do we want This is a hard question... It best to skip this VM and log the error. Line 51: _add_disks(root, params) Line 52: _add_networks(root, params) Line 53: ret.append(params) Line 54: return ret -- To view, visit http://gerrit.ovirt.org/33309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3 Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
