Dan Kenigsberg has posted comments on this change.

Change subject: ip route: parse unreachable and broadcast routes
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/35971/4//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Currently I do not understand why routes like
Line 10: 
Line 11:     unreachable ::ffff:0.0.0.0/96 dev lo  metric 1024  error -101
Line 12:     broadcast 240.0.0.255 dev veth_23  table local  proto kernel  
scope link  src 240.0.0.1
> too long line for commit message?
this is the real output we need to handle.

Unlike Python modules, in commit messages, exceptions are allowed to the 80 
chars rule.
Line 13: 
Line 14: show up on my host, but failure to parse them leads to test failures.
Line 15: 
Line 16: Change-Id: Ia0a882aa1b57dc0c7b26095205b884ae9eff0173


-- 
To view, visit http://gerrit.ovirt.org/35971
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0a882aa1b57dc0c7b26095205b884ae9eff0173
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to