Ondřej Svoboda has posted comments on this change.
Change subject: ip route: parse route flags
......................................................................
Patch Set 5: Verified+1
So many lines of "Could not parse route broadcast/unreachable" are now gone
from supervdsm logs when running testSetupNetworksAddDelDhcp. Only lone "cache"
lines are left and are subject of Dan's follow-up patch.
I am thinking of improving the commit message. I am also confused about
"unreachable" routes but not "broadcast" ones. They are just exclusive to
kernel's "local" routing table.
I ran the parser manually and confirm that the expected flags are now present
(with the value of True) in the output dictionary of Route.parse().
from vdsm.ipwrapper import Route
from vdsm.ipwrapper import routeShowTable
routes = []
for entry in routeShowTable('all'):
try:
route = Route.parse(entry)
except ValueError:
print("parsing failed %s", entry)
else:
routes.append(route)
--
To view, visit http://gerrit.ovirt.org/35971
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0a882aa1b57dc0c7b26095205b884ae9eff0173
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ido Barkan <[email protected]>
Gerrit-Reviewer: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
