Ondřej Svoboda has posted comments on this change. Change subject: ip route: parse route flags ......................................................................
Patch Set 5: (1 comment) PEP8 note and shared sentiment here with Toni. http://gerrit.ovirt.org/#/c/35971/5/lib/vdsm/ipwrapper.py File lib/vdsm/ipwrapper.py: Line 364: route = route[1:] Line 365: Line 366: network = route[0] Line 367: Line 368: data = dict(route[i:i + 2] for i in range(1, len(route), 2)) > I'd say PEP error ([i:i + 2] instead of [i:i+2]), but PEP says OK I think the (good) idea is to have no whitespace around the (mandatory) colon and use spaces to emphasize the operations (which are the real payload here). Line 369: data['network'] = '0.0.0.0/0' if network == 'default' else network Line 370: data.update(flags) Line 371: return data Line 372: -- To view, visit http://gerrit.ovirt.org/35971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0a882aa1b57dc0c7b26095205b884ae9eff0173 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
