Dan Kenigsberg has posted comments on this change.

Change subject: contrib: add useful zsh functions to assist in vdsm development
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/36344/2/contrib/zshrc
File contrib/zshrc:

Line 130:     for f in files:
Line 131:         full_path = os.path.join(d, f)
Line 132:         print 'removing %s' % full_path
Line 133:         os.remove(full_path)
Line 134:  
evil trailing spaces
Line 135: d = '/etc/sysconfig/network-scripts/'
Line 136: for f in os.listdir('/etc/sysconfig/network-scripts/'):
Line 137:     if (f.startswith('ifcfg-bond') or
Line 138:         f.startswith('ifcfg-test-network')):


Line 160:     ./autogen.sh --system && make && \
Line 161:     cd tests && sudo ./run_tests_local.sh $1
Line 162: }
Line 163: 
Line 164: grep_irc () {
unrelated
Line 165:     grep -iR $1 ~/.purple/logs/irc
Line 166: }
Line 167: 
Line 168: logs () {


-- 
To view, visit http://gerrit.ovirt.org/36344
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide4131db838640a5836fd029696849bced267308
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ido Barkan <[email protected]>
Gerrit-Reviewer: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to