Nir Soffer has posted comments on this change. Change subject: contrib: add useful zsh functions to assist in vdsm development ......................................................................
Patch Set 3: (6 comments) Interesting http://gerrit.ovirt.org/#/c/36344/3/contrib/zshrc File contrib/zshrc: Line 9: sudo vdsClient 0 getVdsCaps | less Line 10: else Line 11: sudo vdsClient 0 getVdsCaps Line 12: fi Line 13: } There is no reason to work with non-secure transport, I would make the default the secure version. Line 14: Line 15: scaps() { Line 16: if [ -t 1 ]; then Line 17: sudo vdsClient -s 0 getVdsCaps | less Line 30: vdsm_functional testSetupNetworksAddBondWithManyVlans Line 31: } Line 32: Line 33: vdsm_remove() { Line 34: sudo yum erase -y `rpm -qa | grep vdsm | perl -pe 's|-[0-9].*||' | paste -sd " "` && \ Why not: yum remove -y vdsm\* Line 35: git clean -fdx Line 36: } Line 37: Line 38: vdsm_install() { Line 37: Line 38: vdsm_install() { Line 39: VERSION=`ls ~/rpmbuild/RPMS/x86_64/ -t -w 1 | head -1 | perl -pe 's|^.*?git|git|' | perl -pe 's|\..*$||'` Line 40: FILES=`find ~/rpmbuild/RPMS/ -iname "*$VERSION*.rpm" | egrep "vdsm-[0-9]|python|cli|xmlrpc|jsonrpc|tests|infra"` Line 41: sudo yum install -y `echo $FILES | paste -sd " "` Install usually requires remove, because newer git builds are sometimes older then installed version. So install should include a call to "vdsm-tool configure --force" I think we must have "make install" for this. Line 42: } Line 43: Line 44: vdsm_reinstall() { Line 45: VERSION=`ls ~/rpmbuild/RPMS/x86_64/ -t -w 1 | head -1 | perl -pe 's|^.*?git|git|' | perl -pe 's|\..*$||'` Line 152: Line 153: vdsm_pep8() { Line 154: PEP8_BLACKLIST=config.py,constants.py,crossImportsTests.py,vdsm.py Line 155: /usr/bin/pep8 --exclude=$PEP8_BLACKLIST --filename '*.py,*.py.in' . Line 156: } You can use "make pep8" instead Line 157: Line 158: vdsm_unit () { Line 159: cd ~/code/vdsm && \ Line 160: ./autogen.sh --system && make && \ Line 158: vdsm_unit () { Line 159: cd ~/code/vdsm && \ Line 160: ./autogen.sh --system && make && \ Line 161: cd tests && sudo ./run_tests_local.sh $1 Line 162: } Why run unittests with sudo? We should fix this by fixing the build system, so "nosetests $1" or "py.test $1" work. Line 163: Line 164: logs () { Line 165: less /var/log/vdsm/vdsm.log Line 166: } Line 166: } Line 167: Line 168: super_logs () { Line 169: less /var/log/vdsm/supervdsm.log Line 170: } I'm looking also in /var/log/messages and /var/log/sanlock, so we need something more generic like: log vdsm -> less /var/log/vdsm/vdsm.log log vdsm/supervdsm -> less /var/log/vdsm/supervdsm.log log messages -> less /var/log/messages log sanlock -> less /var/log/sanlock.log -- To view, visit http://gerrit.ovirt.org/36344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide4131db838640a5836fd029696849bced267308 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
