Yeela Kaplan has uploaded a new change for review.

Change subject: multipath configurator: reload only if service is active
......................................................................

multipath configurator: reload only if service is active

If multipathd is active, configuration must be reloaded
actively by vdsm, otherwise it will be reloaded once
multipathd starts.

Configuration will fail only in case multipathd is active
and cannot be reloaded.

Change-Id: Ie1e8eceaaa486f05b1ea4f1733df669b2a44682a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1173487
Signed-off-by: Yeela Kaplan <[email protected]>
---
M lib/vdsm/tool/configurators/multipath.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/36387/1

diff --git a/lib/vdsm/tool/configurators/multipath.py 
b/lib/vdsm/tool/configurators/multipath.py
index 456d5f9..8b40d9b 100644
--- a/lib/vdsm/tool/configurators/multipath.py
+++ b/lib/vdsm/tool/configurators/multipath.py
@@ -145,10 +145,10 @@
         # Flush all unused multipath device maps
         utils.execCmd([constants.EXT_MULTIPATH, "-F"])
 
-        rc = service.service_reload("multipathd")
-        if rc != 0:
-            status = service.service_status("multipathd", False)
-            if status == 0:
+        status = service.service_status("multipathd", False)
+        if status == 0:
+            rc = service.service_reload("multipathd")
+            if rc != 0:
                 raise RuntimeError("Failed to reload Multipath.")
 
     def isconfigured(self, *args):


-- 
To view, visit http://gerrit.ovirt.org/36387
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1e8eceaaa486f05b1ea4f1733df669b2a44682a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to