Yeela Kaplan has posted comments on this change. Change subject: multipath configurator: reload only if service is active ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36387/1/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 146 Line 147 Line 148 Line 149 Line 150 > as I understood the original code, it should have done the right thing alre on rhel7/centos7 when multipathd is inactive and we try to reload then it explodes... That's the exception you see in the bug. This is why I've changed it to check first the status of the service, and we will reload only in case it is active. If it's inactive there's no reason to reload as the configuration will be reloaded once the service starts. -- To view, visit http://gerrit.ovirt.org/36387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e8eceaaa486f05b1ea4f1733df669b2a44682a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
