Yaniv Bronhaim has posted comments on this change. Change subject: multipath configurator: reload only if service is active ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36387/1/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 146 Line 147 Line 148 Line 149 Line 150 > In el7 reload service when the service is inactive returns code of 1, so the code worked properly but in el6 we didn't warn anything.. afaiu we wanted to explode if reload fails and status up? your code will serve it the same way, just you avoid calling reload if the status is not up.. how does it fix the problem? why reload keep failing? -- To view, visit http://gerrit.ovirt.org/36387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e8eceaaa486f05b1ea4f1733df669b2a44682a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
