Yaniv Bronhaim has posted comments on this change. Change subject: tool: autoload modules. ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/34049/9/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 274: return sortedModules Line 275: Line 276: Line 277: def _parse_args(action, *args): Line 278: _load_configurators() > It is not global intentionally: so each call to any configure.py api you load the modules from scratch ? are you sure its ok by saggi? does he aware about that? isn't that a bug? because you use the same list each time. if it was loaded before it will just append the same values. Line 279: parser = argparse.ArgumentParser('vdsm-tool %s' % (action)) Line 280: parser.add_argument( Line 281: '--module', Line 282: dest='modules', -- To view, visit http://gerrit.ovirt.org/34049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cc14a1c409ee607e18d42adcd8a54759d8dbf6d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
