mooli tayer has posted comments on this change. Change subject: tool: autoload modules. ......................................................................
Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/34049/9//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-10-12 01:04:03 +0300 Line 4: Commit: Mooli Tayer <[email protected]> Line 5: CommitDate: 2014-12-25 14:25:59 +0200 Line 6: Line 7: tool: autoload modules. > why remove it ? the change is fine.. just mention the reason for it Because it is a hack. autoloading should not effect the way we import stuff in the autoloaded code. Line 8: Line 9: Change-Id: I6cc14a1c409ee607e18d42adcd8a54759d8dbf6d http://gerrit.ovirt.org/#/c/34049/9/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 274: return sortedModules Line 275: Line 276: Line 277: def _parse_args(action, *args): Line 278: _load_configurators() > so each call to any configure.py api you load the modules from scratch ? loading configurators happends exactly once on each vdsm tool run. It will be so regardless of if we do it on import or not. We can make it more clear by adding if _CONFIGURATORS is not None inside the method Line 279: parser = argparse.ArgumentParser('vdsm-tool %s' % (action)) Line 280: parser.add_argument( Line 281: '--module', Line 282: dest='modules', -- To view, visit http://gerrit.ovirt.org/34049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cc14a1c409ee607e18d42adcd8a54759d8dbf6d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
