Yaniv Bronhaim has posted comments on this change. Change subject: tool: autoload modules. ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/34049/9/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 319: Line 320: Line 321: def _load_configurators(): Line 322: global _CONFIGURATORS Line 323: _CONFIGURATORS = {} oh, you clean it each time.. maybe if its already filled you shouldn't try to reload . I still prefer not to call it in each api call and only in first time you load the module by vdsm-tool Line 324: for module in _listmodules(configurators): Line 325: _CONFIGURATORS[module] = _import_module(configurators, module) Line 326: Line 327: -- To view, visit http://gerrit.ovirt.org/34049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cc14a1c409ee607e18d42adcd8a54759d8dbf6d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
