Petr Horáček has posted comments on this change. Change subject: netlink: event monitor (even more simple version) ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/36197/10/lib/vdsm/netlink/monitor.py File lib/vdsm/netlink/monitor.py: Line 97: finally: Line 98: _close_socket(sock) Line 99: Line 100: def stop(self): Line 101: # after stop, we have to reinit Monitor > Why? Why would a repeated iter() call fail? It was because of i didn't read stop chars from pipetrick. Line 102: os.write(self._pipetrick[1], 'c') Line 103: Line 104: Line 105: # libnl/include/linux/rtnetlink.h -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
