Petr Horáček has posted comments on this change. Change subject: netlink: event monitor (even more simple version) ......................................................................
Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/36197/15/lib/vdsm/netlink/monitor.py File lib/vdsm/netlink/monitor.py: Line 218: yield pipetrick Line 219: finally: Line 220: epoll.unregister(pipetrick[0]) Line 221: finally: Line 222: os.close(pipetrick[0]) i do not open second file descriptor, its number is returned by nl_socket_get_fd() and just passed to poll, so probably it's closed on _close_socket() Line 223: Line 224: -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
