Dan Kenigsberg has posted comments on this change. Change subject: netlink: event monitor (even more simple version) ......................................................................
Patch Set 18: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/36197/18//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-10-30 18:28:23 +0100 Line 4: Commit: Petr Horáček <phora...@redhat.com> Line 5: CommitDate: 2015-01-08 16:34:24 +0100 Line 6: Line 7: netlink: event monitor (even more simple version) future readers of `git log` would not understand " (even more simple version)", so please drop it. Line 8: Line 9: Current event monitor is implemented as a wrapper around `ip monitor` Line 10: command. It is sometimes returned before the underlying monitor is Line 11: properly started. However, it's used just in few tests. Line 6: Line 7: netlink: event monitor (even more simple version) Line 8: Line 9: Current event monitor is implemented as a wrapper around `ip monitor` Line 10: command. It is sometimes returned before the underlying monitor is "is sometimes" ->sometimes Line 11: properly started. However, it's used just in few tests. Line 12: Line 13: We want to implement more natural version of monitor - wrapper around Line 14: the libnl library. With this monitor we will be able e.g. to monitor http://gerrit.ovirt.org/#/c/36197/18/lib/vdsm/netlink/monitor.py File lib/vdsm/netlink/monitor.py: Line 97: scan_thread.start() Line 98: self._running = True Line 99: Line 100: def _scan(self): Line 101: epoll = select.epoll() please see my comments to ps 17. Line 102: try: Line 103: with _monitoring_socket(self._queue, self._groups, epoll) as sock: Line 104: with _pipetrick(epoll) as self._pipetrick: Line 105: while True: -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
