Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Make bootproto4 a boolean and rename it while it is still unused ......................................................................
Patch Set 10: Verified+1 vdsClient -s 0 getVdsCaps works, unit tests pass, functional as well, notably testBrokenNetworkReplacement did not become broken, testDhclientLeases report well and the dreaded testSetupNetworksAddDelDhcp works under good weather conditions. The last test is known to break sometimes on missing/superfluous IP routes or rules (feature: multiple gateways, source routing). I think we will have to use the netlink monitor to wait for routes/rules to (dis)appear because iproute2's commands do not take effect immediately (and overall their behaviour looks random). This patchset is rebased on Ido's fix to vdsm.network.api._delBrokenNetwork(). -- To view, visit http://gerrit.ovirt.org/35984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29abc8db77f2ab12188d6007f072e16ccfd4b223 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
