Ido Barkan has posted comments on this change. Change subject: netinfo: Make bootproto4 a boolean and rename it while it is still unused ......................................................................
Patch Set 10: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/35984/10/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1708: with vethIf() as (left, right): Line 1709: veth.setIP(left, IP_ADDRESS, IP_CIDR) Line 1710: veth.setLinkUp(left) Line 1711: with dnsmasqDhcp(left): Line 1712: dhcpv4 = True This is a constant in this test. it should be inlined. Line 1713: bootproto = 'dhcp' Line 1714: network = {NETWORK_NAME: {'nic': right, 'bridged': bridged, Line 1715: 'bootproto': bootproto, Line 1716: 'blockingdhcp': True}} -- To view, visit http://gerrit.ovirt.org/35984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29abc8db77f2ab12188d6007f072e16ccfd4b223 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches