Petr Horáček has posted comments on this change. Change subject: netlink: event monitor ......................................................................
Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/36197/20/tests/netlinkTests.py File tests/netlinkTests.py: Line 110: {'name': dummy_name, 'type': 'dummy', 'event': 'new_link'}, Line 111: {'label': dummy_name, 'family': 'inet', 'address': IP_ADDRESS + Line 112: '/' + IP_CIDR, 'event': 'new_addr'}, Line 113: {'oif': dummy_name, 'event': 'new_route'}] Line 114: for event in mon: > how about an exact list comparison - after filtering only dummy_name relate different index, scope, assigned address Line 115: for expected_event in expected_events: Line 116: try: Line 117: if all([expected_event[k] == event[k] Line 118: for k in expected_events.keys()]): -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
