Dan Kenigsberg has posted comments on this change. Change subject: netlink: event monitor ......................................................................
Patch Set 19: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/36197/19/lib/vdsm/netlink/monitor.py File lib/vdsm/netlink/monitor.py: Line 195: try: Line 196: obj_dict['event'] = _EVENTS[msg_type] Line 197: except KeyError: Line 198: logging.error('unexpected msg_type %s', msg_type) Line 199: pass what is the point of these funny "pass"s? Line 200: else: Line 201: queue.put(obj_dict) Line 202: _c_object_input = CFUNCTYPE(c_void_p, c_void_p, py_object)(_object_input) Line 203: Line 234: _close_socket(sock) Line 235: Line 236: Line 237: @contextmanager Line 238: def _pipetimeout(epoll, timeout): I think we can do without a second pipe (why waste two more fds?). In any case, please delay timeout to a folow up patch. Line 239: pipetimeout = os.pipe() Line 240: try: Line 241: timer = threading.Timer(timeout, lambda: os.write(pipetimeout[1], 'c')) Line 242: timer.start() -- To view, visit http://gerrit.ovirt.org/36197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
