Adam Litke has posted comments on this change. Change subject: packaging: Added pep8 and pyflakes submodules to vdsm source tree ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37134/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-01-20 07:46:20 -0500 Line 4: Commit: Candace Sheremeta <[email protected]> Line 5: CommitDate: 2015-01-20 12:59:40 -0500 Line 6: Line 7: packaging: Added pep8 and pyflakes submodules to vdsm source tree > I think we should switch to flake8 which is a nice wrapper for pyflake+pep8 Hmm, I actually think the sub-modules are more standard. Libvirt and qemu are both doing this with gnulib and it has been working well for a long time. Line 8: Line 9: Added these submodules to make the build of vdsm slightly smoother, Line 10: as pep8 and pyflakes will not have to be manually installed any longer. Line 11: Pep8 submodule from: https://github.com/jcrocholl/pep8 -- To view, visit http://gerrit.ovirt.org/37134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
