Federico Simoncelli has posted comments on this change. Change subject: packaging: Added pep8 and pyflakes submodules to vdsm source tree ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37134/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-01-20 07:46:20 -0500 Line 4: Commit: Candace Sheremeta <[email protected]> Line 5: CommitDate: 2015-01-20 12:59:40 -0500 Line 6: Line 7: packaging: Added pep8 and pyflakes submodules to vdsm source tree > Hmm, I actually think the sub-modules are more standard. Libvirt and qemu Because there's no standard tool in C for that. The pythonic way (e.g. openstack) is with tox/virtualenv. It's the same for other languages as Go, Ruby, etc. Moreover in C you don't need to test different runtimes, while in python/ruby you have to take in account that as well (py27, py34)... which is something that tox automates very well. We don't have to tackle the entire thing in one patch (e.g. tox), but at least move into that direction. Line 8: Line 9: Added these submodules to make the build of vdsm slightly smoother, Line 10: as pep8 and pyflakes will not have to be manually installed any longer. Line 11: Pep8 submodule from: https://github.com/jcrocholl/pep8 -- To view, visit http://gerrit.ovirt.org/37134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2248ad929b49684d41a40e944c907298deec4daa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
