Nir Soffer has posted comments on this change. Change subject: tests: Changed the unit test code to use permutation. ......................................................................
Patch Set 1: Code-Review+1 (2 comments) Please make this patch depend on another patch fixing the imports, so you can add your new import sorted. http://gerrit.ovirt.org/#/c/38031/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-02-22 15:31:04 +0200 Line 4: Commit: Ala Hino <[email protected]> Line 5: CommitDate: 2015-02-22 16:17:39 +0200 Line 6: Line 7: tests: Changed the unit test code to use permutation. I would describe it: Use permutations for separating test failures. Line 8: Line 9: Change-Id: I7cacc89f9a8ddfef56b3c27234acb0a1cd1f60ed http://gerrit.ovirt.org/#/c/38031/1/tests/miscTests.py File tests/miscTests.py: Line 34: from testlib import VdsmTestCase as TestCaseBase Line 35: from testlib import temporaryPath Line 36: from testlib import namedTemporaryDir Line 37: from testlib import TEMPDIR Line 38: from testlib import permutations, expandPermutations Imports should be sorted - please send another patch sorting this group (lines 33-37) and then insert the new import in the correct location. Line 39: import inspect Line 40: from multiprocessing import Process Line 41: from vdsm import utils Line 42: -- To view, visit http://gerrit.ovirt.org/38031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cacc89f9a8ddfef56b3c27234acb0a1cd1f60ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
