Nir Soffer has posted comments on this change. Change subject: tests: Use permutations for separating test failures ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/38031/5/tests/miscTests.py File tests/miscTests.py: Line 880: self.assertTrue(os.path.lexists(baseDir)) Line 881: Line 882: Line 883: @expandPermutations Line 884: class ReadSpeed(TestCaseBase): Please add empty line between the class and the first test. Previous the test was separated (see line 901 in the previous version). Line 885: @permutations([ Line 886: ("1 byte (1 B) copied, 1 s, 1 B/s", Line 887: "1", "1"), Line 888: ("1024 bytes (1 kB) copied, 1 s, 1 kB/s", -- To view, visit http://gerrit.ovirt.org/38031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cacc89f9a8ddfef56b3c27234acb0a1cd1f60ed Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
