Nir Soffer has posted comments on this change. Change subject: tests: Use permutations for separating test failures. ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/38031/3/tests/miscTests.py File tests/miscTests.py: Line 895: "479", "5.6832e-05"), Line 896: ("512 bytes (512e-3 MB) copied, 1 s, 512e-3 MB/s", Line 897: "512", "1"), Line 898: ("524288 bytes (512e3 B) copied, 1 s, 512e3 B/s", Line 899: "524288", "1") You need to fix the pep8 errors in the previous patch, not here - we cannot merge a patch breaking the build. Line 900: ]) Line 901: def testReadSpeedRegExp(self, output, bytes, seconds): Line 902: m = misc._readspeed_regex.match(output) Line 903: self.assertNotEqual(m, None) -- To view, visit http://gerrit.ovirt.org/38031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cacc89f9a8ddfef56b3c27234acb0a1cd1f60ed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
