Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test ......................................................................
tests: Enhance ReadSpeed.testReadSpeedRegExp unit test Test changed to be more readable. Currently, the test defines a parameterized template and a list of outputs to be tested. For each output, the test replaces the parameters in the template with the corresponding values from the output. This patch makes the test more straightforward by removing the templating mechanism. Change-Id: Iec1eaa570729f8db2e00b19181b94daeedbce23b Signed-off-by: Ala Hino <[email protected]> Reviewed-on: http://gerrit.ovirt.org/38021 Reviewed-by: Nir Soffer <[email protected]> Reviewed-by: Allon Mureinik <[email protected]> Tested-by: Nir Soffer <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/miscTests.py 1 file changed, 19 insertions(+), 12 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/38021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec1eaa570729f8db2e00b19181b94daeedbce23b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
