Nir Soffer has posted comments on this change. Change subject: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/38021/2/tests/miscTests.py File tests/miscTests.py: Line 881: Line 882: class ReadSpeed(TestCaseBase): Line 883: STATS_TESTS = ( Line 884: # output, bytes, seconds Line 885: ("1 byte (1 B) copied, 1 s, 1 B/s", "1", "1"), Lets resolve the pep8 line length limit and make this more readable by separating the output and the expected results: STATS_TESTS = ( ("1 byte (1 B) copied, 1 s, 1 B/s", "1", "1"), ... ) Line 886: ("1024 bytes (1 kB) copied, 1 s, 1 kB/s", "1024", "1"), Line 887: ("1572864 bytes (1.5 MB) copied, 1.5 s, 1 MB/s", "1572864", "1.5"), Line 888: ("1610612736 bytes (1.5 GB) copied, 1000.5 s, 1.53 MB/s", "1610612736", "1000.5"), Line 889: ("479 bytes (479 B) copied, 5.6832e-05 s, 8.4 MB/s", "479", "5.6832e-05"), -- To view, visit http://gerrit.ovirt.org/38021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec1eaa570729f8db2e00b19181b94daeedbce23b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
