Nir Soffer has posted comments on this change. Change subject: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/38021/2/tests/miscTests.py File tests/miscTests.py: Line 896: m = misc._readspeed_regex.match(output) Line 897: self.assertNotEqual(m, None) Line 898: Line 899: self.assertEqual(m.group("bytes"), bytes) Line 900: self.assertEqual(m.group("seconds"), seconds) You removed one blank line here, and pep8 is angry about that. Tip: run "make check" before submitting patches. Line 901: Line 902: class PidExists(TestCaseBase): Line 903: def testPidExists(self): Line 904: """ -- To view, visit http://gerrit.ovirt.org/38021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec1eaa570729f8db2e00b19181b94daeedbce23b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
