Francesco Romani has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError ......................................................................
Patch Set 2: Code-Review-1 (1 comment) I (of course) acknowledge the issue, but I don't think this is the best direction. I'd rather do a bit more monkeypatching _read_password to pick a test-only file, or, maybe into another patch(-set), reorganize libvirtconnection.py to be more flexible. https://gerrit.ovirt.org/#/c/38113/2//COMMIT_MSG Commit Message: Line 12: Both the testcases are lookng for libvirt_password file which will be installed Line 13: with package installation. It is not appropriate for a testcase to look for a Line 14: file which will be installed after the package is installed. Current changes Line 15: will allow testcases to look for the libvirt_password file in sources if the Line 16: file is not present in '/etc/pki/vdsm/keys/libvirt_password' location. trailing whitespaces Line 17: Line 18: Change-Id: Id1de7ed2222c9f531d490ffdd3f71a3130faf63b Line 19: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1195594 -- To view, visit https://gerrit.ovirt.org/38113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1de7ed2222c9f531d490ffdd3f71a3130faf63b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Madhu Pavan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
